Do not include empty nodes in the export output. #4773
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Empty nodes are not included in the export output but the separator (a comma in the case of JSON) is being appended. The fix is to skip over empty values. Added a deleted node to the exported graph to ensure that these type of nodes are handled properly.
danielmai
approved these changes
Feb 13, 2020
There was a problem hiding this comment.
Reviewed 3 of 3 files at r1.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @manishrjain and @MichelDiz)
MichelDiz
approved these changes
Feb 13, 2020
There was a problem hiding this comment.
Reviewed 3 of 3 files at r1.
Reviewable status:
|
@martinmr can you backport this to release/v1.2? |
martinmr
added a commit
that referenced
this pull request
Mar 6, 2020
Empty nodes are not included in the export output but the separator (a comma in the case of JSON) is being appended. The fix is to skip over empty values. Added a deleted node to the exported graph to ensure that these type of nodes are handled properly.
martinmr
added a commit
that referenced
this pull request
Mar 6, 2020
Empty nodes are not included in the export output but the separator (a comma in the case of JSON) is being appended. The fix is to skip over empty values. Added a deleted node to the exported graph to ensure that these type of nodes are handled properly.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Empty nodes are not included in the export output but the separator (a
comma in the case of JSON) is being appended. The fix is to skip over
empty values.
Added a deleted node to the exported graph to ensure that these type of
nodes are handled properly.
Fixes #3610
This change is