-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add /admin/schema endpoint #4777
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 0 of 7 files reviewed, 5 unresolved discussions (waiting on @abhimanyusinghgaur, @manishrjain, @MichaelJCompton, and @pawanrawal)
dgraph/cmd/alpha/http.go, line 570 at r4 (raw file):
} res := map[string]interface{}{}
create a small function for this and reuse below.
graphql/e2e/common/common.go, line 696 at r3 (raw file):
} var addResult struct {
Also check that Errors should be of length 0.
graphql/web/http.go, line 110 at r3 (raw file):
if r.URL.Path == "/admin/schema" { handleAdminSchemaRequest(ctx, w, r, gh)
return here, then you don't need the else below.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 2 of 4 files at r1, 2 of 4 files at r2, 3 of 3 files at r4.
Reviewable status: 5 of 7 files reviewed, 5 unresolved discussions (waiting on @abhimanyusinghgaur, @manishrjain, @MichaelJCompton, and @pawanrawal)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 5 of 7 files reviewed, 5 unresolved discussions (waiting on @golangcibot, @manishrjain, @MichaelJCompton, and @pawanrawal)
dgraph/cmd/alpha/http.go, line 570 at r4 (raw file):
Previously, pawanrawal (Pawan Rawal) wrote…
create a small function for this and reuse below.
Done.
graphql/e2e/common/common.go, line 696 at r3 (raw file):
Previously, pawanrawal (Pawan Rawal) wrote…
Also check that Errors should be of length 0.
Done.
graphql/web/http.go, line 196 at r1 (raw file):
Previously, golangcibot (Bot from GolangCI) wrote…
context.Context should be the first parameter of a function (from
golint
)
Done.
graphql/web/http.go, line 196 at r2 (raw file):
Previously, golangcibot (Bot from GolangCI) wrote…
line is 112 characters (from
lll
)
Done.
graphql/web/http.go, line 110 at r3 (raw file):
Previously, pawanrawal (Pawan Rawal) wrote…
return here, then you don't need the else below.
Done.
This change is
Docs Preview: