-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Set correct posting list type while creating it in live loader. #5012
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have a question but if the answer doesn't require any code changes then this pr
Reviewed 1 of 1 files at r1.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @arijitAD, @manishrjain, and @MichelDiz)
dgraph/cmd/live/batch.go, line 304 at r1 (raw file):
Value: de.GetValue(), } // If the value type is not already set according to the schema, set it to string and
Why is this not needed anymore?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @manishrjain, @martinmr, and @MichelDiz)
dgraph/cmd/live/batch.go, line 304 at r1 (raw file):
Previously, martinmr (Martin Martinez Rivera) wrote…
Why is this not needed anymore?
If the value type is not set according to schema then data will be set to binary type by default and the next line converts the data to the schema type.
* Fix live loader data conversion for conflict key generation. (cherry picked from commit 7bed25a)
* Fix live loader data conversion for conflict key generation. (cherry picked from commit 7bed25a)
* Fix live loader data conversion for conflict key generation.
* Fix live loader data conversion for conflict key generation.
Fixes DGRAPH-1100
Posting list type was not properly set and hence it was panicking while generating tokens.
Tested this with the following data.
Data File
Schema File
The same code for converting the posting list is there in copyValue() in gql/mutation.go
Tested this patch in v20.03.0-beta.20200320 as well.
This change is