Optimize uid allocation in live loader. #5132
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The live loader is having trouble loading exported data with the existing uids because there are too many requests for new uids. The current version requests new Uids to be allocated for every uids greater than the maximum. In the exported data, the uids can come in increasing order, which causes a new request for uids with every NQuad. This PR changes the code to pre-allocate the uids, once per batch of NQuad received from the NQuad buffer channel. Tested it with the 1 million movie data set and now I am getting times similar to the live loader with the --new_uids option enabled. Fixes #4996
manishrjain
approved these changes
Apr 9, 2020
There was a problem hiding this comment.
Reviewed 1 of 1 files at r1.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @martinmr)
dgraph/cmd/live/run.go, line 233 at r1 (raw file):
} oUid, err := strconv.ParseUint(nq.ObjectId, 0, 64)
And here.
manishrjain
approved these changes
Apr 9, 2020
There was a problem hiding this comment.
Reviewable status:
complete! all files reviewed, all discussions resolved
martinmr
added a commit
that referenced
this pull request
Apr 9, 2020
The live loader is having trouble loading exported data with the existing uids because there are too many requests for new uids. The current version requests new Uids to be allocated for every uids greater than the maximum. In the exported data, the uids can come in increasing order, which causes a new request for uids with every NQuad. This PR changes the code to pre-allocate the uids, once per batch of NQuad received from the NQuad buffer channel. Tested it with the 1 million movie data set and now I am getting times similar to the live loader with the --new_uids option enabled. Fixes #4996
dna2github
pushed a commit
to dna2fork/dgraph
that referenced
this pull request
Jul 18, 2020
The live loader is having trouble loading exported data with the existing uids because there are too many requests for new uids. The current version requests new Uids to be allocated for every uids greater than the maximum. In the exported data, the uids can come in increasing order, which causes a new request for uids with every NQuad. This PR changes the code to pre-allocate the uids, once per batch of NQuad received from the NQuad buffer channel. Tested it with the 1 million movie data set and now I am getting times similar to the live loader with the --new_uids option enabled. Fixes dgraph-io#4996
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The live loader is having trouble loading exported data with the
existing uids because there are too many requests for new uids.
The current version requests new Uids to be allocated for every
uids greater than the maximum. In the exported data, the uids can come
in increasing order, which causes a new request for uids with every
NQuad.
This PR changes the code to pre-allocate the uids, once per batch of
NQuad received from the NQuad buffer channel.
Tested it with the 1 million movie data set and now I am getting times
similar to the live loader with the --new_uids option enabled.
Fixes #4996
This change is