Remove isChild from fastJsonNode #5184
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pawanrawal
approved these changes
Apr 13, 2020
There was a problem hiding this comment.
Reviewed 1 of 1 files at r1.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @animesh2049 and @martinmr)
animesh2049
approved these changes
Apr 13, 2020
There was a problem hiding this comment.
Reviewed 1 of 1 files at r1.
Reviewable status:
manishrjain
approved these changes
Apr 13, 2020
There was a problem hiding this comment.
Reviewed 1 of 1 files at r1.
Reviewable status:
ashish-goswami
added a commit
that referenced
this pull request
Apr 22, 2020
While forming JSON response from Subgraph, we build one intermediate data structure called fastJsonNode tree. Each fastJsonNode has some fields which help correct encoding to JSON. isChild and list are also part of these fields. Currently isChild and list are used interchangeably and serve same purpose. This PR remove isChild for simplicity and better readability of the code. (cherry picked from commit 7ea3e4e)
danielmai
pushed a commit
that referenced
this pull request
Apr 24, 2020
While forming JSON response from Subgraph, we build one intermediate data structure called fastJsonNode tree. Each fastJsonNode has some fields which help correct encoding to JSON. isChild and list are also part of these fields. Currently isChild and list are used interchangeably and serve same purpose. This PR remove isChild for simplicity and better readability of the code.
danielmai
pushed a commit
that referenced
this pull request
Apr 24, 2020
While forming JSON response from Subgraph, we build one intermediate data structure called fastJsonNode tree. Each fastJsonNode has some fields which help correct encoding to JSON. isChild and list are also part of these fields. Currently isChild and list are used interchangeably and serve same purpose. This PR remove isChild for simplicity and better readability of the code.
dna2github
pushed a commit
to dna2fork/dgraph
that referenced
this pull request
Jul 18, 2020
While forming JSON response from Subgraph, we build one intermediate data structure called fastJsonNode tree. Each fastJsonNode has some fields which help correct encoding to JSON. isChild and list are also part of these fields. Currently isChild and list are used interchangeably and serve same purpose. This PR remove isChild for simplicity and better readability of the code.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While forming JSON response from
Subgraph, we build one intermediate data structure calledfastJsonNodetree. EachfastJsonNodehas some fields which help correct encoding to JSON.isChildandlistare also part of these fields.Currently
isChildandlistare used interchangeably and serve same purpose. This PR removeisChildfor simplicity and better readability of the code.This change is