Force users to explicitly tell restore command to run without zero. #5206
Conversation
The zero value passed to the command is optional, which can lead to users forgetting about it and being surprised that the cluster does not work (because the uid lease and the timestamp need to be updated first). This change makes the option not optional, unless the --force_no_zero flag is explicitly passed. Not passing a zero value can still be useful when only the p directories need to be generated.
martinmr
requested review from
danielmai,
manishrjain,
MichaelJCompton and
a team
as code owners
There was a problem hiding this comment.
Reviewed 1 of 2 files at r1.
Reviewable status: 1 of 2 files reviewed, 3 unresolved discussions (waiting on @danielmai, @manishrjain, @martinmr, and @MichaelJCompton)
ee/backup/run.go, line 111 at r1 (raw file):
force_no_zero
We should call this force_zero and then make the default true.
--force_zero=false would relax the requirement to connect to Zero.
ee/backup/run.go, line 178 at r1 (raw file):
return errors.Errorf("No zero address passed. Use the --force-no-zero option if you " + "meant to do this") }
"No Dgraph Zero address passed. Use the --force_zero option if you meant to do this"
wiki/content/enterprise-features/index.md, line 181 at r1 (raw file):
optional
We shouldn't say it's optional anymore.
We should say that the --zero option is required unless the other flag is set (--force_zero=false).
There was a problem hiding this comment.
Reviewable status: 0 of 4 files reviewed, 3 unresolved discussions (waiting on @danielmai, @manishrjain, and @MichaelJCompton)
ee/backup/run.go, line 111 at r1 (raw file):
Previously, danielmai (Daniel Mai) wrote…
force_no_zeroWe should call this
force_zeroand then make the default true.
--force_zero=falsewould relax the requirement to connect to Zero.
Done.
ee/backup/run.go, line 178 at r1 (raw file):
Previously, danielmai (Daniel Mai) wrote…
return errors.Errorf("No zero address passed. Use the --force-no-zero option if you " + "meant to do this") }"No Dgraph Zero address passed. Use the --force_zero option if you meant to do this"
Done.
wiki/content/enterprise-features/index.md, line 181 at r1 (raw file):
Previously, danielmai (Daniel Mai) wrote…
optionalWe shouldn't say it's optional anymore.
We should say that the --zero option is required unless the other flag is set (
--force_zero=false).
Done.
There was a problem hiding this comment.
Reviewed 4 of 4 files at r2.
Reviewable status: all files reviewed, 3 unresolved discussions (waiting on @danielmai, @manishrjain, and @MichaelJCompton)
There was a problem hiding this comment.
Reviewable status:
complete! all files reviewed, all discussions resolved (waiting on @manishrjain and @MichaelJCompton)
…5206) The zero value passed to the command is optional, which can lead to users forgetting about it and being surprised that the cluster does not work (because the uid lease and the timestamp need to be updated first). This change makes the option not optional, unless the --force_zero flag is set to false . Not passing a zero value can still be useful when only the p directories need to be generated.
…5206) The zero value passed to the command is optional, which can lead to users forgetting about it and being surprised that the cluster does not work (because the uid lease and the timestamp need to be updated first). This change makes the option not optional, unless the --force_zero flag is set to false . Not passing a zero value can still be useful when only the p directories need to be generated.
|
Cherry-picked to the 1.2 and 20.03 branches. |
…graph-io#5206) The zero value passed to the command is optional, which can lead to users forgetting about it and being surprised that the cluster does not work (because the uid lease and the timestamp need to be updated first). This change makes the option not optional, unless the --force_zero flag is set to false . Not passing a zero value can still be useful when only the p directories need to be generated.
The zero value passed to the command is optional, which can lead to
users forgetting about it and being surprised that the cluster does
not work (because the uid lease and the timestamp need to be updated
first).
This change makes the zero flag required unless the
--force_zeroflag is explicitly passed. Not passing a zero value can still be useful
when only the p directories need to be generated.
Fixes DGRAPH-1251
This change is
Docs Preview: