test(acl): add upgrade tests for ee/acl package #8792
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dgraph-bot
added
area/enterprise
mangalaman93
requested changes
Apr 10, 2023
shivaji-kharse
force-pushed
the
shiva/upgrade2
branch
2 times, most recently
from
79c4b16 to
ca0adfd
Compare
mangalaman93
requested changes
Apr 15, 2023
shivaji-kharse
force-pushed
the
shiva/upgrade2
branch
from
e03168f to
2508c69
Compare
shivaji-kharse
requested review from
akon-dey,
skrdgraph,
darkn3rd,
meghalims,
matthewmcneely and
billprovince
as code owners
mangalaman93
requested changes
Apr 19, 2023
shivaji-kharse
force-pushed
the
shiva/upgrade2
branch
from
e1cddee to
be51e9e
Compare
mangalaman93
requested changes
Apr 26, 2023
shivaji-kharse
force-pushed
the
shiva/upgrade2
branch
2 times, most recently
from
fbc1fe0 to
db8f57e
Compare
mangalaman93
requested changes
May 2, 2023
mangalaman93
force-pushed
the
shiva/upgrade2
branch
from
f92349c to
0b608d6
Compare
shivaji-kharse
force-pushed
the
shiva/upgrade2
branch
2 times, most recently
from
74e924b to
2ecc190
Compare
shivaji-kharse
force-pushed
the
shiva/upgrade2
branch
from
2ecc190 to
5ed866c
Compare
mangalaman93
changed the title
mangalaman93
force-pushed
the
shiva/upgrade2
branch
from
5ed866c to
a6b8809
Compare
mangalaman93
force-pushed
the
shiva/upgrade2
branch
6 times, most recently
from
cabbd02 to
d231b7d
Compare
mangalaman93
previously approved these changes
Jun 10, 2023
mangalaman93
force-pushed
the
shiva/upgrade2
branch
from
d231b7d to
8be8199
Compare
mangalaman93
force-pushed
the
shiva/upgrade2
branch
2 times, most recently
from
423d358 to
1a1ac36
Compare
mangalaman93
previously approved these changes
Jun 12, 2023
harshil-goel
previously approved these changes
Jun 12, 2023
mangalaman93
force-pushed
the
shiva/upgrade2
branch
from
1a1ac36 to
45b1f82
Compare
mangalaman93
requested review from
sanjayk-github-dev,
all-seeing-code and
joshua-goldstein
as code owners
mangalaman93
force-pushed
the
shiva/upgrade2
branch
from
45b1f82 to
ed45f8d
Compare
mangalaman93
changed the title
mangalaman93
previously approved these changes
Jun 29, 2023
mangalaman93
force-pushed
the
shiva/upgrade2
branch
from
ed45f8d to
0f16998
Compare
mangalaman93
approved these changes
Jun 29, 2023
harshil-goel
reviewed
Jul 3, 2023
| } | ||
| return gqlResp.Data, nil | ||
| } | ||
|
|
||
| func (hc *HTTPClient) HealthForInstance() ([]byte, error) { |
There was a problem hiding this comment.
Can you add this api change to description
| @@ -57,7 +57,7 @@ const ( | |||
|
|
|||
| localVersion = "local" | |||
| waitDurBeforeRetry = time.Second | |||
| requestTimeout = 90 * time.Second | |||
| requestTimeout = 120 * time.Second | |||
There was a problem hiding this comment.
@shivaji-dgraph noticed that this is more stable.
| @@ -56,4 +56,10 @@ func init() { | |||
| binDir = filepath.Join(basePath, "binaries") | |||
| encKeyPath = filepath.Join(basePath, "data", "enc-key") | |||
| aclSecretPath = filepath.Join(basePath, "data", "hmac-secret") | |||
|
|
|||
| log.Printf("[INFO] baseRepoDir: %v", baseRepoDir) | |||
There was a problem hiding this comment.
can you add a comment to as to why?
There was a problem hiding this comment.
These are just debugging statements which could be useful when tests fail. Do you have a suggestion as to what I could write here?
|
|
||
| uids := []int{1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14, 15, 16, 17, 18, 19, 20} | ||
| c.AssignUids(gc.Dgraph, uint64(len(uids))) | ||
| require.NoError(t, gc.SetupSchema(`money: [int] @index(int) @count .`)) | ||
|
|
||
| for i := 1; i <= len(uids); i++ { | ||
| for j := 1; j <= i; j++ { | ||
| rdfs := fmt.Sprintf(`<%v> <money> "%v" .`, j, i) | ||
| _, err := gc.Mutate(rdfs) | ||
| mu := &api.Mutation{SetNquads: []byte(fmt.Sprintf(`<%v> <money> "%v" .`, j, i)), CommitNow: true} |
There was a problem hiding this comment.
Through this API, we can do both deletion and set in a mutation.
harshil-goel
approved these changes
Jul 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR also adds HealthForInstance API to dgraphtest package for checking health of Alpha through graphql.