chore(upgrade): run upgrade tests for v23.0.1 #8918
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mangalaman93
requested review from
meghalims,
sanjayk-github-dev,
harshil-goel,
all-seeing-code,
billprovince and
joshua-goldstein
as code owners
mangalaman93
force-pushed
the
aman/upgrade
branch
from
5635309 to
6257f3b
Compare
This PR also fixes a bug in the code that compares the running Dgraph version vs the expected version. It is possible that the version is specified in e.g. long git hash format whereas we use the short git hash format of Dgraph version in the logs.
mangalaman93
force-pushed
the
aman/upgrade
branch
from
6257f3b to
ee8087e
Compare
all-seeing-code
approved these changes
Jul 28, 2023
sanjayk-github-dev
approved these changes
Jul 28, 2023
jbhamra1
pushed a commit
that referenced
this pull request
Aug 17, 2023
This PR also fixes a bug in the code that compares the running Dgraph version vs the expected version. It is possible that the version is specified in e.g. long git hash format whereas we use the short git hash format of Dgraph version in the logs.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR also fixes a bug in the code that compares the running Dgraph version vs the expected version. It is possible that the version is specified in e.g. long git hash format whereas we use the short git hash format of Dgraph version in the logs.