fix(acl): allow data deletion for non-reserved predicates #8937
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dgraph-bot
added
area/core
jbhamra1
force-pushed
the
jassi/defect_dgraphcore_355
branch
from
18c91a1 to
ab19652
Compare
mangalaman93
requested changes
Aug 8, 2023
jbhamra1
force-pushed
the
jassi/defect_dgraphcore_355
branch
4 times, most recently
from
27fa8a1 to
14a0c62
Compare
mangalaman93
requested review from
meghalims,
sanjayk-github-dev,
harshil-goel,
all-seeing-code,
billprovince and
joshua-goldstein
as code owners
mangalaman93
changed the title
mangalaman93
reviewed
Aug 8, 2023
jbhamra1
force-pushed
the
jassi/defect_dgraphcore_355
branch
2 times, most recently
from
de34ea8 to
1cdaf69
Compare
mangalaman93
reviewed
Aug 9, 2023
jbhamra1
force-pushed
the
jassi/defect_dgraphcore_355
branch
from
1cdaf69 to
ca301e8
Compare
mangalaman93
previously approved these changes
Aug 10, 2023
jbhamra1
force-pushed
the
jassi/defect_dgraphcore_355
branch
5 times, most recently
from
f53ab0a to
418b2fe
Compare
mangalaman93
requested changes
Aug 10, 2023
jbhamra1
force-pushed
the
jassi/defect_dgraphcore_355
branch
from
418b2fe to
2c1bb46
Compare
jbhamra1
force-pushed
the
jassi/defect_dgraphcore_355
branch
from
2c1bb46 to
4ba9928
Compare
mangalaman93
approved these changes
Aug 13, 2023
harshil-goel
approved these changes
Aug 16, 2023
jbhamra1
added a commit
that referenced
this pull request
Aug 17, 2023
when data (non-reserved predicates) is added on UIDs that belong to groot user or guardian group, it is allowed. But when the same data is deleted, that is not allowed. This PR allows deletion of non-reserved predicates on special UIDs. Closes: https://dgraph.atlassian.net/browse/DGRAPHCORE-355
jbhamra1
added a commit
that referenced
this pull request
Aug 17, 2023
when data (non-reserved predicates) is added on UIDs that belong to groot user or guardian group, it is allowed. But when the same data is deleted, that is not allowed. This PR allows deletion of non-reserved predicates on special UIDs. Closes: https://dgraph.atlassian.net/browse/DGRAPHCORE-355
mangalaman93
added a commit
that referenced
this pull request
Aug 18, 2023
mangalaman93
added a commit
that referenced
this pull request
Aug 18, 2023
jbhamra1
pushed a commit
that referenced
this pull request
Aug 18, 2023
mangalaman93
pushed a commit
that referenced
this pull request
Aug 21, 2023
when data (non-reserved predicates) is added on UIDs that belong to groot user or guardian group, it is allowed. But when the same data is deleted, that is not allowed. This PR allows deletion of non-reserved predicates on special UIDs. Closes: https://dgraph.atlassian.net/browse/DGRAPHCORE-355
shivaji-kharse
pushed a commit
that referenced
this pull request
Mar 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description: when data (non-reserved predicates) is added on UIDs that belong to groot user or guardian group, it is allowed. But when the same data is deleted, that is not allowed. This PR allows deletion of non-reserved predicates on special UIDs.
Closes: https://dgraph.atlassian.net/browse/DGRAPHCORE-355
Docs: NA