feat(restore): add support for namespace aware restore #8968
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dgraph-bot
added
area/testing
shivaji-kharse
force-pushed
the
shiva/restore
branch
from
509529b to
0f5f89e
Compare
shivaji-kharse
requested review from
mangalaman93,
meghalims,
sanjayk-github-dev,
harshil-goel,
all-seeing-code,
billprovince and
joshua-goldstein
as code owners
mangalaman93
requested changes
Aug 28, 2023
mangalaman93
force-pushed
the
shiva/restore
branch
2 times, most recently
from
9b780b5 to
83f03f3
Compare
mangalaman93
changed the title
mangalaman93
requested changes
Aug 30, 2023
There was a problem hiding this comment.
More todos:
- I do not like the API, oneNamespaceOnly flag. we need to think more.
- Uprgade tests will fail because of the change in cluster.go restore function. It should support both old and new API
- We should test against a fresh cluster when zero doesn't have any tablets
shivaji-kharse
force-pushed
the
shiva/restore
branch
from
83f03f3 to
979facf
Compare
mangalaman93
requested changes
Sep 1, 2023
shivaji-kharse
force-pushed
the
shiva/restore
branch
2 times, most recently
from
af6b376 to
c10fcf0
Compare
mangalaman93
requested changes
Sep 5, 2023
mangalaman93
requested changes
Sep 13, 2023
shivaji-kharse
force-pushed
the
shiva/restore
branch
from
3ec18c7 to
69e5ab4
Compare
mangalaman93
approved these changes
Sep 14, 2023
harshil-goel
approved these changes
Sep 14, 2023
shivaji-kharse
added a commit
that referenced
this pull request
Mar 12, 2024
This commit adds support for namespace aware restore. After this change, we can restore exactly one namespace from a backup of multiple namespaces into the namespace 0 of a dgraph cluster.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds support for namespace aware restore. After this change, we can restore exactly one namespace from a backup of multiple namespaces into a dgraph cluster.