feat(core): Add cache to dgraph.type predicate. #9068
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dgraph-bot
added
area/testing
harshil-goel
force-pushed
the
harshil-goel/mem-cache
branch
from
f58b1ab to
f52b96e
Compare
harshil-goel
commented
Apr 26, 2024
posting/mvcc.go
Outdated
| // corresponding to the key in the cache to nil. So, if we get some non-nil value from the cache | ||
| // then it means that no writes have happened after the last set of this key in the cache. | ||
| if l, ok := countMap.list[string(key)]; ok { | ||
| if l != nil && l.maxTs < readTs { |
There was a problem hiding this comment.
l.minTs < readTs
mangalaman93
requested changes
May 19, 2024
posting/mvcc.go
Outdated
| @@ -1,25 +1,24 @@ | |||
| /* | |||
posting/mvcc.go
Outdated
| type GlobalCache struct { | ||
| sync.RWMutex | ||
|
|
||
| count map[string]int |
There was a problem hiding this comment.
use a struct instead! More maps => more memory unpredictability
harshil-goel
force-pushed
the
harshil-goel/mem-cache
branch
from
d9529ba to
fab7c2d
Compare
harshil-goel
changed the title
mangalaman93
approved these changes
May 23, 2024
| return int64(0) | ||
| } | ||
| return int64(l.DeepSize()) | ||
| return 0 |
There was a problem hiding this comment.
please make a comment to describe why the change
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add cache to dgraph.type predicate. This would significantly help improve @filter(type) queries.
Live loader before took: 16mins 39 seconds for 21 million dataset.
Live loader now: 10mins 52 seconds.
Improvement: 38%