chore(deps): bump github.com/spf13/cast from 1.3.1 to 1.7.0 #9141
Conversation
![dependabot[bot]](https://avatars.githubusercontent.com/in/29110?s=60&v=4){kind=small}
dependabot
bot
added
dependencies
|
@dependabot rebase |
|
Looks like this PR has been edited by someone other than Dependabot. That means Dependabot can't rebase it - sorry! If you're happy for Dependabot to recreate it from scratch, overwriting any edits, you can request |
|
@dependabot recreate |
Bumps [github.com/spf13/cast](https://github.com/spf13/cast) from 1.3.1 to 1.7.0. - [Release notes](https://github.com/spf13/cast/releases) - [Commits](spf13/cast@v1.3.1...v1.7.0) --- updated-dependencies: - dependency-name: github.com/spf13/cast dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>
dependabot
bot
force-pushed
the
dependabot/go_modules/github.com/spf13/cast-1.7.0
branch
from
cb4e57b
to
cead0c0
Compare
|
@ryanfoxtyler This PR & #9143 both have an issue causing a integration2 tests to fail. I spent some time looking into it when I was working on the PR #9115. It is pretty strange that an upgrade such as this causing our bulk loader to behave different. I couldn't get to the bottom of it then. |
|
@mangalaman93 agreed it's odd that these dependency bumps are failing consistently on this test. These test suites are still flaky at times, so perhaps this change is moving it from flaky to always failing? Seeing this error on
We've seen this before, right? |
1 similar comment
|
@mangalaman93 agreed it's odd that these dependency bumps are failing consistently on this test. These test suites are still flaky at times, so perhaps this change is moving it from flaky to always failing? Seeing this error on
We've seen this before, right? |
|
the error you posted is just a transient error, not a fatal error. We should be more clear about that in the logs. The test suites are a lot less flaky now from before after we fixed the issue with tcp6. I completely agree that we need to do more and we will keep working on that as we observe them. For now, I will look into this issue and figure out what is going on. Most likely a dep of this upgrade is affecting something. I will post my conclusions and hopefully it reduces the flakyness too. |
|
@shivaji-dgraph and I were looking into this and we found out a bug in the This affects Dgraph because we use math.MaxUint64 as our default value that viper is unable to parse due to this bug. |
|
OK, I won't notify you about version 1.x.x again, unless you re-open this PR. |
dependabot
bot
deleted the
dependabot/go_modules/github.com/spf13/cast-1.7.0
branch
Bumps github.com/spf13/cast from 1.3.1 to 1.7.0.
Release notes
Sourced from github.com/spf13/cast's releases.
Commits
6e0c3abSupport some commonly used Float64 interfaces6c5f3fcgithub: Bump versions48ddde5Bump Go version in go.mod to 1.19b09a6f8deps: update to github.com/frankban/quicktest v1.14.6268227cgithub: Replace the test workflow with the one used in Aferoe9ba3ceMerge pull request #190 from spf13/updates9d37e3aci: fix dependabot configa441ac7ci: pin actions versions, fix checkout order9c5e91ddocs: update badgesc49a664ci: rename ci.yml to ci.yamlYou can trigger a rebase of this PR by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot mergewill merge this PR after your CI passes on it@dependabot squash and mergewill squash and merge this PR after your CI passes on it@dependabot cancel mergewill cancel a previously requested merge and block automerging@dependabot reopenwill reopen this PR if it is closed@dependabot closewill close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)