Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(cd): release v23.0.1 #205

Merged
merged 1 commit into from
May 31, 2023
Merged

Conversation

joshua-goldstein
Copy link
Contributor

@joshua-goldstein joshua-goldstein commented May 30, 2023

This fixes protobuf import issues. For more info see #204 . To try new release, pip install pydgraph==23.0.1rc1.

This fixes protobuf import issues.  For more info see #204 .
@joshua-goldstein
Copy link
Contributor Author

Before merging this, waiting for @MichelDiz 's input since he also noticed issues with the other release. Would be good to get his feedback.

@MichelDiz
Copy link
Contributor

Tested

grpcio
protobuf
pydgraph==23.0.1rc1
six==1.16.0
schedule

And it worked fine.

Also tested like

grpcio
protobuf
pydgraph
six==1.16.0
schedule

And this one failed.

Previously I was using(and still until this get fixed)

grpcio==1.38.1
protobuf==3.18.3
pydgraph==21.3.0
six==1.16.0
schedule

@joshua-goldstein
Copy link
Contributor Author

joshua-goldstein commented May 31, 2023

Many thanks @MichelDiz . Looks like it is working as expected. You probably already know, but for others reading this thread: since we only pushed an rc release, one would have to run pip install --pre pydgraph or pip install pydgraph==v23.0.0rc1 to pick up the latest rc1.

Tested

grpcio
protobuf
pydgraph==23.0.1rc1
six==1.16.0
schedule

And it worked fine.

Great, this is the main thing I wanted to make sure about.

Also tested like

grpcio
protobuf
pydgraph
six==1.16.0
schedule

And this one failed.

Yes, since this is picking up v23.0.0 (not v23.0.1rc1).

Previously I was using(and still until this get fixed)

grpcio==1.38.1
protobuf==3.18.3
pydgraph==21.3.0
six==1.16.0
schedule

That looks correct for v21.3.0, which requires protobuf < 4. Note that it is not necessary to install grpcio and protobuf directly via pip. We pin to specific versions of these dependencies in the pyproject.toml, so when someone does a pip install pydgraph==v23.0.1 (or, after this release, simply pip install pydgraph) it will automatically download grpcio==1.54.0 and protobuf==4.22.3.

@joshua-goldstein joshua-goldstein merged commit a4d4b28 into master May 31, 2023
@joshua-goldstein joshua-goldstein deleted the joshua/v23.0.1-release branch May 31, 2023 03:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants