Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support vertx? #12

Open
cocodrino opened this issue Mar 29, 2015 · 5 comments
Open

support vertx? #12

cocodrino opened this issue Mar 29, 2015 · 5 comments

Comments

@cocodrino
Copy link

Hello!..vertx has a small ring adapter, unfortunately this block and it doesnt take advantages of vertx, which is pretty bad considering than the main advantage for vertx is than it's async non blocking..would be really cool adapt spiral to vertx...

https://github.com/stream1984/ring-vertx-adapter

@dgrnbrg
Copy link
Owner

dgrnbrg commented Mar 29, 2015

I think that's a great idea! Would you like to look into the feasibility of it?

@cocodrino
Copy link
Author

Hi..sorry I'm not a clojure expert nor vertx, hopefully @tobias or @stream1984 can give you a better point of view.....

@dgrnbrg
Copy link
Owner

dgrnbrg commented Mar 30, 2015

Does the ring vertx adapter support an async mode?

@tobias
Copy link
Contributor

tobias commented Apr 9, 2015

The vertx ring adapter is currently not async. After looking at spiral, I think a better approach is to borrow the pieces of the adapter that translate between a vertx request and ring request/response maps, and use those directly in a vertx-adapter for spiral. I don't do much with vertx anymore, but would be happy to guide anyone who wanted to take this on.

@dgrnbrg
Copy link
Owner

dgrnbrg commented Apr 9, 2015

Likewise, I'd be happy to explain any necessary spiral internals.

On Wed, Apr 8, 2015 at 8:19 PM Toby Crawley notifications@github.com
wrote:

The vertx ring adapter is currently not async. After looking at spiral, I
think a better approach is to borrow the pieces of the adapter that
translate between a vertx request and ring request/response maps, and use
those directly in a vertx-adapter for spiral. I don't do much with vertx
anymore, but would be happy to guide anyone who wanted to take this on.


Reply to this email directly or view it on GitHub
#12 (comment).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants