Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update to pmd 7 #177

Closed
wants to merge 1 commit into from
Closed

update to pmd 7 #177

wants to merge 1 commit into from

Conversation

emouty
Copy link
Contributor

@emouty emouty commented Sep 20, 2024

Many thanks for your contribution, we truly appreciate it. We will appreciate it even more, if you make sure that you can say "YES" to each point in this short checklist:

  • You made a small amount of changes (less than 100 lines, less than 10 files)
  • You made changes related to only one bug (create separate PRs for separate problems)
  • You are ready to defend your changes (there will be a code review)
  • You don't touch what you don't understand
  • You ran the build locally and it passed

This article will help you understand what we are looking for: http://www.yegor256.com/2015/02/09/serious-code-reviewer.html

Thank you for your contribution!

@emouty emouty closed this Sep 20, 2024
@dgroup
Copy link
Owner

dgroup commented Sep 23, 2024

Thanks, will check soon

@emouty
Copy link
Contributor Author

emouty commented Sep 23, 2024

The PR is not ready, I wanted to open it on my fork to check diff but I targeted the wrong repo

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants