Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix wrong boolean values parsing #8

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

alpiquero
Copy link

bool type fields were parsing at line 152 using

data[k] = bool(v)

This will always return True if the content of the v variable is not the empty string.

I changed that line to

data[k] = str(v).lower() == 't'

@MikelMoreno
Copy link

Hi @dgunter,

Could you please add the opened pull requests to the branch? (Goes for #8 #9 #10 too)

This are minor changes but can help people get the clean version of the project without having to modify the code themselves.

Thanks in advance!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants