Skip to content
This repository has been archived by the owner on Dec 30, 2018. It is now read-only.

Use new Some and None constructors #9

Merged
merged 1 commit into from
Sep 10, 2018
Merged

Conversation

Gabriella439
Copy link
Contributor

This also removes ./Optional/{Some,None} since they are now obsolete

This also reformats all the files, which is why there are some unrelated changes

I've made the matching changes to dhall-lang/dhall-haskell#559
to verify that the updated examples are correct

This also removes `./Optional/{Some,None}` since they are now obsolete
@f-f
Copy link
Member

f-f commented Sep 7, 2018

@Gabriel439 should we add this repo as submodule of dhall-haskell?
It would avoid the whole two-copies-of-prelude-go-out-of-sync issue in the future.

Copy link
Member

@f-f f-f left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great, Some/None make things quite more readable 👏

@Gabriella439
Copy link
Contributor Author

@f-f: Yes, we should. I'm going to do that after merging the corresponding Haskell pull request

@Gabriella439 Gabriella439 merged commit 0c83aed into master Sep 10, 2018
@Gabriella439 Gabriella439 deleted the gabriel/some_none branch September 10, 2018 19:01
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants