Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support lsp-1.5 #2428

Closed
wants to merge 1 commit into from
Closed

Support lsp-1.5 #2428

wants to merge 1 commit into from

Conversation

sjakobi
Copy link
Collaborator

@sjakobi sjakobi commented Jun 20, 2022

No description provided.

@sjakobi
Copy link
Collaborator Author

sjakobi commented Jun 20, 2022

This is still WIP, because I haven't figured out how to migrate parts of the code yet, e.g. haskell/lsp#441.

@sjakobi
Copy link
Collaborator Author

sjakobi commented Jun 20, 2022

BTW, I was wondering whether it's truly necessary or useful to maintain backwards compatibility with lsp and other libraries in dhall-lsp-server. After all, I strongly suspect that no-one is using this package as a library and would therefore have a need for backwards compatibility.

@michaelpj
Copy link

I highly recommend not trying to retain backwards compatibility with lsp. It's still moving relatively fast, and I anticipate releasing more breaking changes in the future. For HLS we pin to a particular version.

@sjakobi sjakobi mentioned this pull request Jul 14, 2022
Closed
33 tasks
@mmhat mmhat mentioned this pull request Oct 25, 2023
Merged
@Vekhir Vekhir mentioned this pull request Dec 23, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sjakobi @michaelpj @Gabriella439