Remove metadata.name from podTemplate #138
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
makes it more in-line with a normal Kubernetes deployment example
TristanCacqueray
approved these changes
Aug 12, 2020
|
I think I also need to update the files in Would also be nice that we test that |
|
Oh indeed, it seems like the hydra job does not check that. |
|
it used to though if I remember correctly ... did something change? :/ |
|
@arianvp: It did check this. I'm also surprised, and I'm looking into this. |
|
@arianvp: It looks like the issue is that after my changes CI only checks the versioned releases, but not the top-level default release. I'll put up a PR soon to fix that |
Gabriella439
added a commit
that referenced
this pull request
Sep 11, 2020
… based on the discussion in #138 CI wasn't checking that the `./scripts/generate.sh` script had been run, which this change fixes
Gabriella439
added a commit
that referenced
this pull request
Sep 11, 2020
… based on the discussion in #138 CI wasn't checking that the `./scripts/generate.sh` script had been run, which this change fixes
Gabriella439
added a commit
that referenced
this pull request
Sep 11, 2020
… based on the discussion in #138 CI wasn't checking that the `./scripts/generate.sh` script had been run, which this change fixes
Gabriella439
added a commit
that referenced
this pull request
Sep 12, 2020
… based on the discussion in #138 CI wasn't checking that the `./scripts/generate.sh` script had been run, which this change fixes
|
@arianvp: Alright, CI is fixed now to catch when things get out of sync. See the CI error on this pull request after merging in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
makes it more in-line with a normal Kubernetes deployment example. This field is even ignored by kubernetes API for PodTemplates afaik
Also
deploymentSimplewas missing aselectorwhich is invalid (runtime error)