Fix tracking which branches are already true or false in conditionals #56
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, only one list of already-seen conditions was kept, and this was assumed to be the list of 'true' conditions. But that was also being added to in the false branch! We actually need to keep two lists, one of already-true and one of already-false. Fixes dhall-lang#53. Fixes dhall-lang#55.
Since these are represented specially in Cabal's CondTree type, this is worth testing explicitly.
…al into quasicomputational-issue-53
…asicomputational-issue-53
|
Perfect! Thank you for adding tests, and good job understanding what the hell this code does! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, only one list of already-seen conditions was kept, and
this was assumed to be the list of 'true' conditions. But that was
also being added to in the false branch! We actually need to keep two
lists, one of already-true and one of already-false.
Fixes #53. Fixes #55.