Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: add autotools & cmake #23

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Conversation

mochaaP
Copy link

@mochaaP mochaaP commented Mar 13, 2024

The old Makefile is renamed to GNUmakefile, and is prioritized by GNU Make.

To do an out-of-source build with Autotools:

  • mkdir build/ && ../configure && make

To make a dist tarball:

  • make dist

Signed-off-by: Zephyr Lykos <git@mochaa.ws>


By submitting this PR, you agree to the following:

  • This contribution is dedicated to the public domain per the COPYING file included in this distribution. I am waiving any copyright claims with respect to this contribution, and I assert that this contribution is my own creation, and not taken from another work.

mochaaP added 2 commits March 13, 2024 18:39
Signed-off-by: Zephyr Lykos <git@mochaa.ws>
Signed-off-by: Zephyr Lykos <git@mochaa.ws>
@dhess
Copy link
Owner

dhess commented Mar 20, 2024

I appreciate the effort you've put into this PR. It looks comprehensive and carefully done.

However, I have prior experience maintaining a relatively popular open source project written in C/C++, and autotools and co. were an absolute PITA to maintain. In fact, one of the reasons I originally released this project without any packaging is that I didn't want to go anywhere near another autotools project.

Additionally, it's been my experience that adding cross-platform packaging creates the expectation that you're offering to support a multitude of different platforms (including Windows), and in the process make the implementation less straightforward, but a straightforward implementation is one of the primary goals of this project. There've been quite a few requests for changes to support this platform or that (or compiler, or memory model, or threads implementation, etc.), but I've felt comfortable rejecting most of them on the grounds that this project isn't a proper package, as such, and is instead intended to be used as a starting point for use in your own application.

Therefore, I'm inclined to reject this PR, as I did in #20. I am seriously considering relicensing the project per your request in #22. Assuming I do that, I would then encourage you to fork the project and package it, if you're up for maintaining it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants