-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: enable ou tree and levels/groups with user orgunits and display decent title (DHIS2-18066) #1702
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add jest tests for both OrgUnitDimension and getOuLevelAndGroupText. (Copilot can help, also look at PeriodDimension for doing a test on a component)
I'm pretty sure you can remove the mocks from the test. |
## [26.9.3](v26.9.2...v26.9.3) (2024-11-22) ### Bug Fixes * enable ou tree and levels/groups with user orgunits (DHIS2-18066) ([#1702](#1702)) ([f58c708](f58c708))
🎉 This PR is included in version 26.9.3 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Implements DHIS2-18066
Description
The ability to combine the ou tree and levels/groups with user orgunits is a very powerful and useful feature for users. This was supported earlier, but it was enable due to problems with e.g. priting labels in a meaningful way.
We have decided to re-enable this feature as users really want need it. A fix has been included so that the filter title in pivot tables at least says e.g. "Facility level in User organisation unit" instead of "Facility level in USER_ORG_UNIT".
TODO
Screenshots
Before - Org unit selector - When User organisation unit is selected, the tree and levels/groups get disabled):
After - Org unit selector - All option enabled:
After - Org unit selector - All three user orgunit options selected and a level: