feat: cache param for expression dimension items (DHIS2-13871) #1433
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
janhenrikoverland
changed the base branch from
master
to
feat/DHIS2-13871-custom-calculations
src/modules/dataTypes.js
Outdated
| @@ -6,6 +6,8 @@ export const DIMENSION_TYPE_DATA_ELEMENT = 'DATA_ELEMENT' | |||
| export const DIMENSION_TYPE_DATA_SET = 'DATA_SET' | |||
| export const DIMENSION_TYPE_EVENT_DATA_ITEM = 'EVENT_DATA_ITEM' | |||
| export const DIMENSION_TYPE_PROGRAM_INDICATOR = 'PROGRAM_INDICATOR' | |||
| export const DIMENSION_TYPE_EXPRESSION_DIMENSION_ITEM = | |||
There was a problem hiding this comment.
Im a bit surprised that GH doesn't pick up that this change already exists in my branch (https://github.com/dhis2/analytics/pull/1370/files?show-viewed-files=true&file-filters%5B%5D=#diff-64e11558ada84b560c86145d9ac2a5eb6c83a7f24fc40ef088b7f40aa2cbec48R21) 🤔
There was a problem hiding this comment.
It's on a different line though (I put it last), should be easy enough to detect if we end up with duplicates though
There was a problem hiding this comment.
Moved it to the same line, but still not picked up.
martinkrulltott
approved these changes
Feb 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements a small part of DHIS2-13871
hashcreates a deterministic fixed-length hash of the input string, it's a separate function with its own test to make it easy to replace the hash function latergetHashaccepts a string or an array of strings and returns the hash produced byhashgetExpressionHashFromVisualizationgrabs the expressions (looks fordimensionItemTypeandexpression), if any EDIs in the visualization, then sorts them by id to get a cache hit as often as possible (now the order of the selected EDI items doesn't matter), and returns the result fromgetHashIn AnalyticsRequest we add the hash as a param
edi_cacheif there are EDIs in the visualization.