Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: add data-test to modal and data elements (DHIS2-13871) #1455

Merged
merged 3 commits into from
Apr 27, 2023

Conversation

martinkrulltott
Copy link
Contributor

@martinkrulltott martinkrulltott commented Apr 25, 2023

Implements DHIS2-13871

Relates to dhis2/data-visualizer-app#2232

--

Adds data-test props related to custom calculations

<div
className="chip"
onDoubleClick={() => onDoubleClick(data)}
data-test={'data-element-option'}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can just write data-test="data-element-option", right?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@martinkrulltott martinkrulltott marked this pull request as ready for review April 27, 2023 12:50
@martinkrulltott martinkrulltott merged commit 784655d into master Apr 27, 2023
@martinkrulltott martinkrulltott deleted the test/calculation-data-test-props branch April 27, 2023 12:51
@dhis2-bot
Copy link
Contributor

🎉 This PR is included in version 25.1.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants