feat: support options for multi axes (DHIS2-6672) #890
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
edoardo
reviewed
Jun 1, 2021
src/visualizations/config/adapters/dhis_highcharts/yAxis/index.js
Outdated
Show resolved
Hide resolved
src/visualizations/config/adapters/dhis_highcharts/yAxis/index.js
Outdated
Show resolved
Hide resolved
…index.js Co-authored-by: Edoardo Sabadelli <edoardo@dhis2.org>
…index.js Co-authored-by: Edoardo Sabadelli <edoardo@dhis2.org>
edoardo
approved these changes
Jun 1, 2021
dhis2-bot
added a commit
that referenced
this pull request
Jun 1, 2021
# [18.2.0](v18.1.4...v18.2.0) (2021-06-01) ### Features * support options for multi axes (DHIS2-6672) ([#890](#890)) ([a3ad56e](a3ad56e))
|
🎉 This PR is included in version 18.2.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements DHIS2-6672
Relates to dhis2/data-visualizer-app#1692
Requires dhis2/app-platform#552
Key features
Description
Combines the handling of single axis and multi axis into a uniformed axis handling, to enable all options regardless of how many axes are used.
dhis2/app-platform#552 is needed for the plural handling to work properly.
Generates axis titles based on if multi axes are used and/or the amount of data items are in use, see the screenshots in the DV PR for more info on what it looks like.