chore: release alpha #389
Merged
chore: release alpha #389
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Husky will be removed to allow easier implementation for: 1. Opt-in Git hooks 2. Yarn 2 support BREAKING CHANGE: Husky has been removed from cli-style. You will need to remove hooks that reference husky.sh in .git/hooks.
refactor: remove husky
# [8.0.0-alpha.1](v7.2.3...v8.0.0-alpha.1) (2020-12-16) ### Code Refactoring * remove husky ([752b944](752b944)) ### BREAKING CHANGES * Husky has been removed from cli-style. You will need to remove hooks that reference husky.sh in .git/hooks.
It is possible to install all available git hooks with:
d2-style install git-hooks/all
Or specific hooks with e.g.
d2-style install git-hooks/commit-msg
# [8.0.0-alpha.2](v8.0.0-alpha.1...v8.0.0-alpha.2) (2020-12-16) ### Features * opt-in git hooks ([#333](#333)) ([a3bc415](a3bc415))
# [8.0.0-alpha.3](v8.0.0-alpha.2...v8.0.0-alpha.3) (2020-12-16) ### Features * **eslint:** add import order rule ([#334](#334)) ([c7b9991](c7b9991))
This removes the `--quiet` flag from the ESLint invocation, and fixes the broken output where ESLint complains about us trying to lint dot-files and folders by un-ignoring their built-in ignore filters. We agree with ignoring node_modules in terms of linting however, so that is left in place.
"d2-style" no longer tries to obfuscate what tools are used under the hood, and leans into being a friendly helper to nudge developers to comply with the dhis2 code style and guidelines. New features: - "d2-style <check/apply>" can now run all configured linters and formatters in a single command, making it easier to use. - "d2-style <add/remove>" is used to add configuration files for individual tools, e.g. eslint, prettier, etc. - "d2-style add" supports templates for e.g. react using: d2-style add eslint react - "d2-style install" reads the project configuration from .d2/style.config.js and sets up the project in accordance to that. BREAKING CHANGE: The verb (check/apply) is now moved to the top-level. E.g. "d2-style js check" becomes "d2-style check js". This is to allow all checkers to run with a single command: "d2-style check" BREAKING CHANGE: "d2-style install" is no longer used to set up linters. As of husky@5 the tool is vastly simplified and much faster. Hooks can be installed manually with "d2-style install", but is also run as a "post-install" script that we control for consistency. Configuration is added to the project with the "d2-style add" command.
# [8.0.0-alpha.5](v8.0.0-alpha.4...v8.0.0-alpha.5) (2021-04-07) ### Features * new and improved d2-style ([#378](#378)) ([f8279e5](f8279e5)) ### BREAKING CHANGES * The verb (check/apply) is now moved to the top-level. E.g. "d2-style js check" becomes "d2-style check js". This is to allow all checkers to run with a single command: "d2-style check" * "d2-style install" is no longer used to set up linters. As of husky@5 the tool is vastly simplified and much faster. Hooks can be installed manually with "d2-style install", but is also run as a "post-install" script that we control for consistency. Configuration is added to the project with the "d2-style add" command.
# [8.0.0-alpha.6](v8.0.0-alpha.5...v8.0.0-alpha.6) (2021-04-07) ### Bug Fixes * match files from project root ([b77ef35](b77ef35))
# [8.0.0-alpha.7](v8.0.0-alpha.6...v8.0.0-alpha.7) (2021-04-07) ### Features * delete deprecated configuration files ([c961647](c961647))
This introduces ls-lint to check the file system for consistent naming
of files and folders.
Installed using:
yarn d2-style add ls-lint
Can be run individually:
yarn d2-style check fs
If it is configured (i.e. .ls-lint.yml exists), then it will run on:
yarn d2-style check
# [8.0.0-alpha.8](v8.0.0-alpha.7...v8.0.0-alpha.8) (2021-04-08) ### Features * lint file system for consistent names ([#379](#379)) ([2bfb5ef](2bfb5ef))
# [8.0.0-alpha.9](v8.0.0-alpha.8...v8.0.0-alpha.9) (2021-04-21) ### Bug Fixes * allow eslint to print colors ([#384](#384)) ([c95a184](c95a184))
* fix: wrong hooks where installed by default * fix: resolve d2style config from project over package
ghost
requested review from
ghost
mentioned this pull request
This is done, I believe. We only add the |
There are a few workarounds, but we can deal with those in a separate PR as |
varl
approved these changes
May 5, 2021
Ah yeah you're right. 👍 |
I checked it out thinking it would be a quick fix, but I couldn't really find a decent way to quickly address it. I'll create an issue for it: https://jira.dhis2.org/browse/CLI-41 |
|
🎉 This PR is included in version 8.0.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@HendrikThePendric mentioned here: dhis2/ui#580 that there are changes on cli-style@alpha that fix the editor integration for eslint. @varl and I were looking at the alpha branch a while back (see here: dhis2/scheduler-app#174). I've taken a look, and from my perspective the only things that came up there that we hadn't addressed yet are:
The workflow change doesn't have to be addressed in cli-style, and the other two aren't critical in my opinion. I think we could merge alpha to master as far as I'm concerned (all critical things I could find during testing are fixed). What do you think @varl?