fix: prevent re-rendering/flashing of maps and charts [DHIS2-14979] [v40] #2266
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* fix: solve most unwanted re-renders of dashboard items This is basically reverting a change I added to solve a DV Highchart's cutoff issue. I think I found another approach for that issue which does not require to pass style to the plugin, which is a problem because of course it changes any time the dashboard item container changes size (window resize, resize of other dashboard items, interpretation panel toggle, etc...). * chore: bump cli-app-scripts to solve no-service-worker issue
jenniferarnesen
force-pushed
the
fix/re-rendering-v40
branch
from
ea3a185 to
98430d7
Compare
|
🚀 Deployed on https://pr-2266--dhis2-dashboard.netlify.app |
Passing run #3195 ↗︎
Details:
This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. |
|||||||||||||||
jenniferarnesen
force-pushed
the
fix/re-rendering-v40
branch
from
a18b029 to
9c0e41e
Compare
edoardo
approved these changes
Mar 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes https://dhis2.atlassian.net/browse/DHIS2-14979
Visualizations were re-rendering/flashing, causing extra api requests which could be a performance issue on slower connections