fix: merge to master #2965
Merged
fix: merge to master #2965
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Automatically merged.
|
🚀 Deployed on https://pr-2965--dhis2-dashboard.netlify.app |
Fixes: https://dhis2.atlassian.net/browse/DHIS2-12499 The plugin was changed and now just directly uses the value of the displayProperty. Analytics requests expects 'name' or 'shortName'. Meanwhile, fetching dimensions and dimensionItems still expects 'displayName' or 'displayShortName'.
martinkrulltott
approved these changes
Apr 23, 2024
If a dashboard item description contained newlines (paragraphs), they were being removed when displaying the visualization description
Passing run #4773 ↗︎
Details:
Review all test suite changes for PR #2965 ↗︎ |
|||||||||||||||
|
🎉 This PR is included in version 100.2.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note that this commit does not fix any shortName issues in the legacy plugins (EV and ER)