-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: improve support for right-to-left languages in Dashboard app #2985
Open
kabaros
wants to merge
18
commits into
master
Choose a base branch
from
DHIS2-16777/rtl-support
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bumps [express](https://github.com/expressjs/express) from 4.18.1 to 4.19.2. - [Release notes](https://github.com/expressjs/express/releases) - [Changelog](https://github.com/expressjs/express/blob/master/History.md) - [Commits](expressjs/express@4.18.1...4.19.2) --- updated-dependencies: - dependency-name: express dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com>
kabaros
force-pushed
the
DHIS2-16777/rtl-support
branch
from
May 31, 2024 19:16
dd58c05
to
da03e77
Compare
kabaros
force-pushed
the
DHIS2-16777/rtl-support
branch
from
June 1, 2024 19:13
da03e77
to
a5e27fc
Compare
kabaros
force-pushed
the
DHIS2-16777/rtl-support
branch
from
June 3, 2024 09:29
a5e27fc
to
1083b47
Compare
….19.2 chore(deps): bump express from 4.18.1 to 4.19.2
🚀 Deployed on https://pr-2985--dhis2-dashboard.netlify.app |
@kabaros There is a lint error in ItemGrid.css. Could you look into it? |
@kabaros Maybe I'm doing something wrong here, but I can't get the app to run locally: |
I went ahead and changed it according to the recommendation. Please check that my change is correct. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements DHIS2-16778
Key features
cli-style
to a version that supports checking logical properties (and automatically converting physical to logical properties)Description
This PR implements better support for right-to-left languages in the app, by leveraging the use of logical CSS properties that are independent of language direction, rather than physical properties (i.e.
*-start
instead of-left
and*-end
instead*-right
). Logical properties are widely supported now and they should become the default way for layout going-forward to ensure that we support RTL languages without extra development burden (which will be enforced byd2 style
).Although the change set is big. It's mostly done automatically using
d2 style apply css
which under the hood uses stylelint to enforce and apply the rules.The better support for RTL builds on top of previous work done in the platform, namely:
d2.config
that allows apps to declare they're ready to support RT. The platform changes also takes care of setting the correct direction and language for the header among other things: feat: add configurabledir
for language directions to app adapter [DHIS2-16480] app-platform#825Testing
Screenshots