fix: force visualization fetch to ensure recording for offline #3196
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The visualization request stopped being recorded after recent changes. The componentDidUpdate method was taking care of the recording, but it doesn't work as before. This change ensures the visualization is fetched when the dashboard is marked for offline so that the request is properly cached.
edoardo
changed the base branch from
master
to
feat/custom-plugins-rebased-latest
|
🚀 Deployed on https://pr-3196.dashboard.netlify.dhis2.org |
| @@ -96,6 +96,11 @@ class Item extends Component { | |||
| await apiFetchVisualization(this.props.item) | |||
| ) | |||
|
|
|||
| // force fetch when recording to allow caching of the visualizations request | |||
| if (this.props.isRecording) { | |||
| apiFetchVisualization(this.props.item) | |||
There was a problem hiding this comment.
There is no need to await this request?
It does look a bit weird to have the same request 5 lines above.
Also, no chance that this request would get triggered twice?
There was a problem hiding this comment.
I don't think we need to await because we are not using the returned value.
The other fetch above needs the returned value for setting it in the Redux store.
I don't think it can be triggered twice because the recording can only happen once the dashboard is loaded.
But this needs testing.
…st' into fix/missing-offline-request-recording
|
jenniferarnesen
merged commit 42aa33a
into
feat/custom-plugins-rebased-latest
24 of 29 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Key features
Description
The visualization request stopped being recorded after recent changes. The componentDidUpdate method was taking care of the recording, but it doesn't work as before.
This change ensures the visualization is fetched when the dashboard is marked for offline so that the request is properly cached.