-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: backport multi-calendar functionality into 38.x #2239
Conversation
🚀 Deployed on https://pr-2239--dhis2-data-visualizer.netlify.app |
8bd2ada
to
d71ceb5
Compare
Passing run #1693 ↗︎
Details:
This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. |
d71ceb5
to
62d4625
Compare
I tested that the multi-calendar periods are working on this back-port. I had to change some settings for the e2e tests to make them pass as well.
|
tested it works on the deploy link pointing to: https://debug.dhis2.org/2.38dev |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Change look good, thanks @kabaros ! I'd just recommend using a caret range (^21.9.0
) instead of pinning the version of analytics.
packages/app/package.json
Outdated
@@ -13,7 +13,7 @@ | |||
"redux-mock-store": "^1.5.4" | |||
}, | |||
"dependencies": { | |||
"@dhis2/analytics": "^21.8.2", | |||
"@dhis2/analytics": "21.9.0", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@kabaros should this be pinned to 21.9.0
or should it be an open range ^21.9.0
? I think the latter for consistency unless there's a strong reason to pin the version
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
no, no strong reasons - updated it now.
62d4625
to
7aad9fa
Compare
7aad9fa
to
1b9518c
Compare
🎉 This PR is included in version 38.3.9 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Implements LIBS-471
Requires dhis2/analytics#1439
Key features
Screenshots
From deploy link