refactor: Clean up description call to rule engine #117
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
enricocolasante
commented
Dec 20, 2023
•
enricocolasante
commented
- EventDate must use Instant instead of LocalDate
- Check logs are working in dhis2-core
- Clean up code and interface
vgarciabnz
reviewed
Jan 15, 2024
jbee
approved these changes
Jan 16, 2024
Comment on lines
+3
to
+7
| data class RuleAction( | ||
| val data: String?, | ||
| val type: String, | ||
| val values: Map<String, String> = emptyMap() | ||
| ){ |
vgarciabnz
reviewed
Jan 17, 2024
enricocolasante
commented
Jan 17, 2024
enricocolasante
added a commit
that referenced
this pull request
Jan 17, 2024
* chore: RuleContent and RuleEffects as records * chore: RuleEvaluationResult as record * chore: RuleValidationResult as record * chore: removed unused TimeInterval * chore: DataItem as record * chore: RuleEngineExecution as record * chore: RuleEngineMultipleExecution as record * chore: RuleVariableValue as record * chore: RuleEnrollment, RuleEvent as record * chore: removed unused class SupplementaryData * chore: RuleEngine as record * chore: RuleVariableValueMap as record * chore: cleanup RuleVariableValueMapBuilder * chore: RuleAction hierarchy as records * chore: RuleDataValue as record * chore: general cleanup * chore: RuleVariable hierarchy as records and interfaces * chore: RuleAttributeValue as record * chore: RuleActionAttribute hierarchy to records * chore: general cleanuo * chore: test cleanup * chore: removed unused dependency * chore: remove common lang dependency * chore: replace joda time with java.time * chore: removed equalsverifier dependency * chore: replaced assertj with vanilla junit * chore: replace @nullable with @checkfornull * chore: removed mockito dependency * chore: replace slf4j with java.util.logging * chore: removed apache commons dependency * chore: replace Arrays.asList with List.of * chore: replace Arrays.asList with List.of * chore: general cleanup * chore: use KMP expression parser snapshot * refactor: RuleEngine, RuleValidationResult, AttributeType to kotlin * refactor: RuleEngineTest to kotlin * refactor: RuleActionHideField to kotlin * refactor RuleActionHideProgramStage to kotlin * refactor enums to kotlin * refactor rule effects to kotlin * put list of envs back * Update github actions * refactor utils to kotlin * refactor option and dataItem to kotlin * refactor ruleVariableValueMap to kotlin * refactor ruleVariableValueMap to kotlin * refactor Rule to kotlin and all related tests * refactor RuleEvent to kotlin * refactor RuleEngineContext to kotlin * refactor RuleEnrollment to kotlin * refactor RuleVariable to kotlin * Make data for RuleEffect optional * refactor RuleVariableValue to kotlin * refactor hide actions to kotlin * refactor more actions to kotlin * refactor send actions to kotlin * refactor mandatory action to kotlin * refactor message action to kotlin * refactor rule values to kotlin * refactor assign action to kotlin * last conversions to kotlin * Allow null data for actions * Add type for text actions * Bump shanpshot version * Create KMP structure * Remove java.util.Callable usages * Remove java.util.Map usages * Remove Logger and Dates usages * Move implementation to common * Move tests to common * Move tests to common * refactor: Clean up description call to rule engine (#117) * refactor: Clean up description call to rule engine * refactor: Clean up evaluation call to rule engine * refactor: Clean up evaluation call to rule engine * refactor: EventDate changed from LocalDate to Instant * Refactor package structure * Refactor package structure * Fix RuleAction interface * Fix RuleAction interface * Fix RuleEngine API interface * Make engine package internal * Make rule engine getInstance static for Java * Update build.gradle.kts --------- Co-authored-by: Enrico <enrico@dhis2.org> Co-authored-by: Victor Garcia <vgarciabnz@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.