fix: Use createDate as secundary order param [DHIS2-18093] #139
Conversation
| val value = currentEventValues[field] | ||
| val optionValue = if (useCodeForOptionSet) value!!.value else getOptionName(value!!.value)!! | ||
| RuleVariableValue( | ||
| fieldType, optionValue, | ||
| listOf(optionValue), getLastUpdateDate(listOf(value)) | ||
| ) | ||
| listOf(optionValue), ruleEvent!!.eventDate.toLocalDateTime(TimeZone.currentSystemDefault()).date.toString()) |
There was a problem hiding this comment.
Just a comment, not necessarily something to change now. In general, I will try to avoid the use of !! because it just throws a NPE without any other information. Something such as
requireNotNull(ruleEvent) { "Event must not be null in CurrentEvent variables" }
might be more meaningful.
|
I would say the right version should be |
I would go with |
|
About format plugins, the android sdk uses two plugins that could be easily added in this repo, not necessarily both of them (actually they overlap a little bit):
|
eventDateandprogramStagefields fromRuleDataValue. These values are deduced fromRuleEventcreatedDatefield inRuleEvent.Refactor
RuleVariableValueMapBuilderto remove most ofMutableMaps and!!operator.@vgarciabnz Would be difficult to add a formatted plugin to the repository?
The correct version should be
3.1.0? As we introduced breaking changes?