-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: support min & max date, DD-MM-YYYY date format #36
Merged
Merged
Changes from 11 commits
Commits
Show all changes
13 commits
Select commit
Hold shift + click to select a range
114d9e3
feat: support minDate & maxDate
alaa-yahia aca9828
fix: return `format` from extractDatePartsFromDateString
alaa-yahia 137baa2
chore: expose validatiation from useDatePicker hook
alaa-yahia ee02312
chore: refactor code
alaa-yahia 73262da
feat: add nepali date validation
alaa-yahia b48ac89
chore: pass failing tests
alaa-yahia ed41085
fix: linter issues
alaa-yahia d6f72e4
chore: refactor code
alaa-yahia 331c617
chore: refactor code
alaa-yahia 88040b4
fix: add types
alaa-yahia 88c6dc9
Merge branch 'alpha' into support-minDate-&-maxDate
alaa-yahia 98fc090
chore: add missing tests
alaa-yahia 2f6c5c4
fix: format warnings
alaa-yahia File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -620,3 +620,49 @@ it('should generate the correct calendar weeks when passed "Ethiopian" rather th | |
['27', '28', '29', '30', '1', '2', '3'], | ||
]) | ||
}) | ||
|
||
describe('validation rules', () => { | ||
it('should validate correct format', () => { | ||
const onDateSelect = jest.fn() | ||
const date = '2015-' | ||
const options = { | ||
// minDate: '2015-06-28', | ||
// calendar: 'iso8601' as SupportedCalendar, | ||
} | ||
const renderedHook = renderHook(() => | ||
useDatePicker({ onDateSelect, date, options }) | ||
) | ||
const result = renderedHook.result?.current as UseDatePickerReturn | ||
|
||
expect(result.isValid).toEqual(false) | ||
}) | ||
it('should validate min', () => { | ||
const onDateSelect = jest.fn() | ||
const date = '2015-06-22' | ||
const options = { | ||
// calendar: 'iso8601' as SupportedCalendar, | ||
} | ||
const minDate = '2015-06-28' | ||
const maxDate = '2018-06-28' | ||
const renderedHook = renderHook(() => | ||
useDatePicker({ onDateSelect, date, options, minDate, maxDate }) | ||
) | ||
const result = renderedHook.result?.current as UseDatePickerReturn | ||
|
||
expect(result.isValid).toEqual(false) | ||
}) | ||
|
||
it('should validate max date', () => { | ||
const onDateSelect = jest.fn() | ||
const date = '2019-06-22' | ||
const options = {} | ||
const minDate = '2015-06-28' | ||
const maxDate = '2018-06-28' | ||
const renderedHook = renderHook(() => | ||
useDatePicker({ onDateSelect, date, options, minDate, maxDate }) | ||
) | ||
const result = renderedHook.result?.current as UseDatePickerReturn | ||
|
||
expect(result.isValid).toEqual(false) | ||
}) | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. could you also add similar tests for ethiopic and nepali calendars please |
||
}) |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
remove commented out code please