Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: localise validation message in multi calendar #61

Merged
merged 4 commits into from
Aug 28, 2024

Conversation

alaa-yahia
Copy link
Member

@alaa-yahia alaa-yahia commented Aug 27, 2024

Implements LIBS-649

@alaa-yahia alaa-yahia requested a review from kabaros August 27, 2024 06:02
@codecov-commenter
Copy link

codecov-commenter commented Aug 27, 2024

Codecov Report

Attention: Patch coverage is 57.14286% with 3 lines in your changes missing coverage. Please review.

Project coverage is 90.93%. Comparing base (c93f789) to head (3f73710).
Report is 1 commits behind head on alpha.

Files Patch % Lines
...om-period-id/create-fixed-period-from-period-id.ts 0.00% 1 Missing ⚠️
...d-id/get-yearly-fixed-period-type-for-period-id.ts 0.00% 1 Missing ⚠️
src/utils/from-any-date.ts 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##            alpha      #61   +/-   ##
=======================================
  Coverage   90.93%   90.93%           
=======================================
  Files          56       56           
  Lines        1191     1191           
  Branches      322      322           
=======================================
  Hits         1083     1083           
  Misses        106      106           
  Partials        2        2           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kabaros kabaros changed the title feat: localise validation message in multi calendar fix: localise validation message in multi calendar Aug 28, 2024
@kabaros kabaros merged commit ead860b into alpha Aug 28, 2024
9 checks passed
dhis2-bot added a commit that referenced this pull request Aug 28, 2024
# [1.3.0-alpha.2](v1.3.0-alpha.1...v1.3.0-alpha.2) (2024-08-28)

### Bug Fixes

* localise validation message in multi calendar ([#61](#61)) ([ead860b](ead860b))
@dhis2-bot
Copy link
Contributor

🎉 This PR is included in version 1.3.0-alpha.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

dhis2-bot added a commit that referenced this pull request Sep 24, 2024
# [1.3.0](v1.2.4...v1.3.0) (2024-09-24)

### Bug Fixes

* format undefined when thers is a mismatch ([79b54fd](79b54fd))
* localise validation message in multi calendar ([#61](#61)) ([ead860b](ead860b))
* remove unnecessary console warn ([b2d795d](b2d795d))

### Features

* expose function to convert dates ([622f0eb](622f0eb))
* expose function to convert dates ([9d42640](9d42640))
* expose methods for converting between iso8601 and calendars ([#37](#37)) ([33fa25d](33fa25d))
* reararnge memorized variables so that we only recompute them when necessary ([b754dcc](b754dcc))
* support min & max date, DD-MM-YYYY date format  ([#36](#36)) ([3b2e57e](3b2e57e))
* **validation:** add and expose validateDateString utility ([cb4c919](cb4c919))
@dhis2-bot
Copy link
Contributor

🎉 This PR is included in version 1.3.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants