fix: cron parsing number range [DHIS2-18859]

dhis2 · Jan 21, 2025 · a87fa32 · a87fa32 · dhis2-bot · Jan 21, 2025
2 parents f029f67 + 0593b44
commit a87fa32
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 1 deletion.
diff --git a/src/services/validators/validate-cron.js b/src/services/validators/validate-cron.js
@@ -28,7 +28,7 @@ const isValidNumberRange = (range, x, y) => {
     return (
         isValidNumber(boundaries[0], x, y) &&
         isValidNumber(boundaries[1], x, y) &&
-        boundaries[0] <= boundaries[1]
+        Number(boundaries[0]) <= Number(boundaries[1])
     )
 }
 

diff --git a/src/services/validators/validate-cron.test.js b/src/services/validators/validate-cron.test.js
@@ -36,6 +36,10 @@ describe('validateCron', () => {
         expect(validateCron('0 0 1-5 * * *')).toBe(true)
     })
 
+    it('should parse numbers properly in number ranges', () => {
+        expect(validateCron('0 0 4-23 * * *')).toBe(true)
+    })
+
     it('should allow ranges in fraction numerators', () => {
         expect(validateCron('0 0 10-22/2 ? * *')).toBe(true)
     })