Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[C4GT] ] Collective: Add tests for DelegateNotFound #285

Open
3 tasks
vatsa287 opened this issue Feb 5, 2024 · 5 comments
Open
3 tasks

[C4GT] ] Collective: Add tests for DelegateNotFound #285

vatsa287 opened this issue Feb 5, 2024 · 5 comments
Assignees
@Atharva-developer
Labels
C4GT Community good first issue Good for newcomers

Comments

@vatsa287
Copy link
Member

vatsa287 commented Feb 5, 2024 •
edited
Loading

Description

Subtask under : cord-network/community#7

New testcase can be tested under cargo test -p pallet-collective after adding it in the code.

Goals

  • Add tests for DelegateNotFound for pallet/collective

Expected Outcome

  • Test should assert for DelegateNotFound being returned properly in all the possible calls.
  • If there are more than one function returning this error code, all of them should be validated either as one test case or as multiple test cases.

Acceptance Criteria

NA

Implementation Details

Look at other test cases, and add a test case for the same.
Ex: motions_ignoring_non_collective_proposals_works which validates error code NotMember

Mockups / Wireframes

NA

Product Name

CORD

Organization Name

Dhiway

Domain

Blockchain

Tech Skills Needed

Rust

Mentor(s)

@amarts

Complexity

[Low]

Category

[Test]

Sub Category

[Beginner friendly]
@amarts amarts added the good first issue Good for newcomers label Feb 6, 2024
Aloneking789 added a commit to Aloneking789/cord that referenced this issue Mar 25, 2024
@Aloneking789
tests.rs
1c286c8 
Fixes dhiway#285 
We're creating a new test function check_delegate_not_found.
We use the ExtBuilder::default().build_and_execute() function to set up the test environment.
We create a proposal with some arbitrary value .
Attempt to propose using a non-existent delegate .
@Aloneking789 Aloneking789 mentioned this issue Mar 25, 2024
Closed
@trishanu-init
Copy link

@vatsa287 Please assign this issue to me

@VedantKhairnar
Copy link

Hello @trishanu-init
Any update on the contribution?
Pls do let us know if you need any assistance.
Thanks.

@trishanu-init
Copy link

I am sorry sir, i am unable to work on this issue right now due to ongoing exams.....please assign this to someone else

@huamanraj
Copy link
Contributor

huamanraj commented Dec 13, 2024 •
edited
Loading

Hi @vatsa287 ,
I'd like to work on this issue.
Could you please assign it to me?

@Atharva-developer
Copy link
Contributor

Hello @vatsa287, I would like to contribute in this particular issue.
So, kindly assign me this issue, I'll try to get it done soon!
Thank You!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Atharva-developer Atharva-developer

Labels
C4GT Community good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

tests.rs Aloneking789/cord
6 participants
@amarts @VedantKhairnar @vatsa287 @trishanu-init @huamanraj @Atharva-developer