Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[C4GT] Statement: Add tests for StatementRevoked #314

Closed
3 tasks
vatsa287 opened this issue Feb 6, 2024 · 12 comments · Fixed by #358
Closed
3 tasks

[C4GT] Statement: Add tests for StatementRevoked #314

vatsa287 opened this issue Feb 6, 2024 · 12 comments · Fixed by #358
Labels

Comments

@vatsa287
Copy link
Member

vatsa287 commented Feb 6, 2024

Description

Subtask under : cord-network/community#7

New testcase can be tested under cargo test -p pallet-statement after adding it in the code.

Goals

  • Add tests for StatementRevoked for pallet/statement

Expected Outcome

  • Test should assert for StatementRevoked being returned properly in all the possible calls.
  • If there are more than one function returning this error code, all of them should be validated either as one test case or as multiple test cases.

Acceptance Criteria

NA

Implementation Details

Look at other test cases, and add a test case for the same.
Ex: check method trying_to_update_a_non_registered_statement_should_fail which validates error code StatementNotFound

Mockups / Wireframes

NA


Product Name

CORD

Organization Name

Dhiway

Domain

Blockchain

Tech Skills Needed

Rust

Mentor(s)

@amarts

Complexity

[Low]

Category

[Test]

Sub Category

[Beginner friendly]

@vatsa287 vatsa287 changed the title [C4GT] Schema: Add tests for StatementRevoked [C4GT] Statement: Add tests for StatementRevoked Feb 6, 2024
@vatsa287 vatsa287 added the good first issue Good for newcomers label Feb 8, 2024
@Sriramkashyapks
Copy link
Contributor

Issue #314: Adding Tests for StatementRevoked

Dear vatsa287 , as a beginner contributor, I'm eager to take on issue #314. I'm motivated to learn, dedicated to the project's standards, and see this as a valuable learning opportunity. Please consider assigning it to me. Thank you.

Best, Sriram Kashyap

@vatsa287
Copy link
Member Author

@Sriramkashyapks Welcome! You can start working on this and send the PR. You can have a reference with #342.

@ninja-mayank
Copy link

@vatsa287 , as a beginner I am interested to take on issue #314. I have gone through the code and am confident that I can resolve it. Please consider assigning it to me. Thank you

@vatsa287
Copy link
Member Author

@ninja-mayank Welcome! I see a open PR for this already. If possible you can send PR for anything which has no PR submitted yet.

@Sayanjones
Copy link

@vatsa287 I'm interested on this project. Can we discuss further?

@rising0raj
Copy link

Hey @vatsa287 I would like to work on this . I have gone through the code base can you assign this to me if it is open??

@Yashhatwar22
Copy link

Hey, @vatsa287 I'm a beginner, I have gone through the code base, would like to work on this , Can you assign it if it is open?

@vatsa287
Copy link
Member Author

@ninja-mayank Welcome! I see a open PR for this already. If possible you can send PR for anything which has no PR submitted yet.

@Yashhatwar22 @rising0raj @Sayanjones ^^

@Gaurang3110
Copy link

@vatsa287
Hello sir , i am eager to contribute to this project and also as a beginner , it will help me to start learning about different stuffs and will also play a major role in my starting phase.
so can you please assign this to me ?

@g-nitin-1
Copy link

@vatsa287
Hello Sir, I am a beginner in rust Programming language can you provide any resource to learn Rust programming language

@Sohajawdekar
Copy link

Hey @vatsa287 ! I am interested in working on this project and reviewed the codes and prerequisites. Can you please assign this issue to me ?

@26vanshika
Copy link

Hey @vatsa287, I am interested to work upon this issue pls assign me

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

10 participants