tests: Add test for InvalidIdentifierLength
#322
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes: dhiway#280 Signed-off-by: Shreeevatsa N <vatsa@dhiway.com>
vatsa287
commented
Feb 8, 2024
| @@ -190,7 +190,7 @@ impl Ss58Identifier { | |||
| Ok(Self( | |||
| Vec::<u8>::from(v.to_base58()) | |||
| .try_into() | |||
| .map_err(|_| IdentifierError::InvalidIdentifierLength)?, | |||
| .map_err(|_| IdentifierError::InvalidIdentifier)?, | |||
There was a problem hiding this comment.
This is being triggered even when vector length is set to 40.
Ideally should be returned OK()
There was a problem hiding this comment.
@vatsa287 open a separate issue for this, and lets move ahead with merging this testcase, which checks for IdentifierLength.
amarts
approved these changes
Feb 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements test-case for error-code InvalidIdentifierLength for chain-space pallet.
When Identifier Length < 2 or Identifier Length > 49.
Fixes: #280
Signed-off-by: Shree Vatsa N vatsa@dhiway.com
[TODO: For this to pass (currently fails even length is below 49) have to change error codes emitted in
primitives/identifier]