Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Chromedriver Version #19

Merged
merged 3 commits into from
Aug 9, 2019
Merged

Update Chromedriver Version #19

merged 3 commits into from
Aug 9, 2019

Conversation

tnoetzel
Copy link
Contributor

@tnoetzel tnoetzel commented Aug 8, 2019

The Chromedriver version is outdated and causes Peppermint to fail if you have the latest version of Chrome Installed.

This PR updates Chromedriver to the latest version.

The Chromedriver version is outdated and causes Peppermint to fail if you have the latest version of Chrome Installed.
@dhleong
Copy link
Owner

dhleong commented Aug 9, 2019

Hey thanks for your PR!

I'm not sure the dependency name is right? It says "version" instead of "chromedriver." Also, if you could keep the original whitespace I would appreciate that.

@tnoetzel
Copy link
Contributor Author

tnoetzel commented Aug 9, 2019

Ugh, my bad. All fixed now.

@dhleong dhleong merged commit 5b8a48a into dhleong:master Aug 9, 2019
@dhleong
Copy link
Owner

dhleong commented Aug 9, 2019

Looks good, thanks!

@dhleong
Copy link
Owner

dhleong commented Aug 9, 2019

Released as 2.1.3; thanks again!

This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants