Migrate to Typescript #22
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This could possibly be a peerDependency so users install the version they need?
Also entails a massive refactoring of this ancient code to a more modern, maintainable style
driver.findElement apparently acts as an assert; since we're waiting *until* the element exists, we shouldn't assert too early. I've seen this error once; it's unclear how to trigger it, however...
Probably good, to avoid having multiple, independent EventEmitters
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR represents a heavy refactor, migrating all existing functionality in a mostly API-compatible way to Typescript. Auth handling in particular has been cleaned up, simplified, and even slightly improved in some cases. At the very least, it's much easier to follow and maintain, now.
As part of the Typescript rewrite, core PepperMint method arguments now have strong types so it's easier to get things right, and their return types are also strongly-typed, making it easier to explore the API.
Breaking Changes
The only breaking change is that we no longer use
Qfor promises, and instead use native promises. This should only be a problem if you used the deprecated.fail()method instead of the standard.catch()The
PepperMint.sessionCookiesproperty no longer exists. If you really want access to the cookies, you can usePepperMint.auth.cookies, but per notes in the README it is probably not worth saving these cookies due to a short lifetime.Deprecations
The
getRefreshingAccountIds()method is now deprecated. You should prefergetRefreshingProviderIds()instead, which does the exact same thing, but its name actually matches what it returns.getRefreshingAccountIds()may be removed in a future release.