RemotePlay-based Connection #18
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dhleong
force-pushed
the
dhleong/remote-play-connection
branch
from
4829cf1
to
e0dcf59
Compare
I think we ought to be able to reuse the TcpDeviceSocket logic for sending and receiving packets...
Probably unnecessary since it *should* be 16 bytes
In particular, this resulted in us getting an incomplete RP-Key, which was the cause of our consistently failed auth attempts at the ctrl endpoint
This simplifies some code sharing, and gives us one spot to validate RP-Key
Not quite sure what's going on...
We have to ref() it to prevent the agent from killing things
Also cleans up RemotePlayDeviceConnection somewhat
Standby now works properly for PS5!
dhleong
force-pushed
the
dhleong/remote-play-connection
branch
from
26e352a
to
4c8e375
Compare
The BufferPacketProcessor sort of assumes that the whole stream is encoded, but that's not how the RemotePlay protocol works.
Just in case order is significant
In the RemotePlay protocol, we should *only* increment the counters if there was actually a payload to encrypt/decrypt. We were *always* trying to encrypt/decrypt, which incorrectly incremented counters, causing a desync with the host device. Passcode auth works now!
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR sets up the initial support for implementing IDeviceConnection using the RemotePlay protocol. Included is basic login and standby support. Probably will want to try to support login passcode support before merging.
Of note: there was a bug in how we handled login, so the credentials needed to actually login are probably incomplete if you used that method. This situation will be detected and you should be notified of the need to re-authenticate. We don't yet (but probably should) add a flag to ignore existing credentials to force re-auth for this case.
It looks like we can additionally support the on-screen-keyboard with this API, but button presses may be a separate API, and there may not be an equivalent for starting apps/games.