Refactor CLI code to get babel-ified and generally be more maintainable #114
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Refs #108 The general approach here is that each command should be simple to write with an easy means of operating against a provided UI and device. That way we can test against mocks/fakes and also easily swap out a different "UI" implementation. I don't plan to add a GUI, but this would make it easier to support `--json` mode, or even possibly a headless stdin-based daemon mode. I've decided against oclif because it just seems like too much, but commander.js or yargs seem like good options.
Refs #108 Yargs has some great stuff but I don't like how it renders the options info. Commander.js seems very close, but it doesn't wrap descriptions at all. docopt and neodoc seem neat but don't let us nicely and succinctly describe what each command does. Minimist is simple and easy, and doesn't introduce any new dependency overhead, so let's just stick with it!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #108
I don't anticipate adding any new commands, but #40 has been around for a while and should become fairly trivial to implement with this refactor. Also, now that commands are fairly trivially testable it would be less painful for someone to look into #104.
Besides, let's be honest... the old code was pretty much garbage. This is at least somewhat better. There's still a bunch of code that's begging to be cleaned up (Waker in particular is nasty) but it's functional, so let's not take on unnecessary risk by trying to rewrite it. This code did actually have some bugs (see #113) and otherwise blocked other issues (as mentioned above) so it was worth doing.