Improve dev UX with proper function arglists #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For the common case, this produces smaller, more efficient javascript, and also automatically gives us a useful arglist in the function docs. However, it won't work if there's any destructuring in the params vector.
This certainly adds some complexity, but since it's all handled at compile time, so there's no overhead at runtime. It also means that in the general cases you can get better experiences, but we still support the fancy case if anybody wants to do that.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As mentioned in the comments, we don't seem to be able to generate good arglists if your factory has variadic args, but I suspect this is an uncommon case. In the common case of a simple args vector we can use the original vector directly, which reduces the amount of code generated; and in the less-common case where destructuring is used for a fixed number of args we can still generate a nice
:arglistsmeta that hides the implementation details.Fixes #2