Initial groundwork for DM Screen / Campaign UI #103
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Refs #69 Mostly just ensures sheets are loaded; styling to come... eventually
Refs #69 This is not 100% bullet-proof, but it's relatively painless to use in place of an existing subscription, and it allows those subscriptions to *optionally* be used with an arbitrary sheet-id, for use on character cards for a campaign page.
Refs #69 The character card is starting to look useful!
Refs #69 Basically the DM has to add them to the DM sheet, then the player has to open a special "invite" link to "accept" (IE: save the "campaign" field in their own sheet). Sort of an extra step, but reasonable, I think.
Also makes it possible to hot-swap routes, which is just fantastic
We'd probably like to expand the "update-notifier" functionality to be more general so we can show "Campaign joined!" or something as we enter the sheet page
It's about time for this branch to get merged; there's a ton of refactoring in it already; all the remaining features can be done in one or more seperate branches. The only thing we really need to do before merging is allow players to detach the campaign from their character.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #69
This includes some huge refactors to make this possible, including a modification to many core subscriptions so they can optionally accept a sheet ID to reference instead of the "current" ID. Currently the Campaign UI is pretty empty except for the Character Carousel, which lets the DM quickly view some core stats, but we can add more features later.
Besides the UI features mentioned in the above-referenced ticket, some noticeable absences from this PR:
These can be added as and when needed to implement the desired features.