Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make simulations design consistent with rest of the site #438

Merged
merged 6 commits into from
May 16, 2019

Conversation

ryaanahmed
Copy link
Member

This PR adds the panel design pattern to simulations, and moves things around a bit for compactness and ease of use.

@equationcrunchor -- let me know what you think.

Annotation 2019-05-15 152248

@mscuthbert
Copy link
Member

I like a lot better! General memory can probably have less space between the lines and probably even less padding since it's less important.

I'm thinking that for the accumulator and storage register, giving the decimal or octal code for the value also might be useful. (hexadecimal wasn't used nearly as much as octal at the time).

@ryaanahmed
Copy link
Member Author

I like a lot better! General memory can probably have less space between the lines and probably even less padding since it's less important.

Great. Will fix spacing. Padding is mostly because we have an awkward amount of stuff and I couldn't think of a better layout... doesn't make sense to stretch the code box out further. The layout isn't quite there, I think, but good enough for now.

I'm thinking that for the accumulator and storage register, giving the decimal or octal code for the value also might be useful. (hexadecimal wasn't used nearly as much as octal at the time).

Will make an issue and leave this for later improvement.

Copy link
Collaborator

@equationcrunchor equationcrunchor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it looks good enough for merge, just some possible future improvements:

  • The code in the demos unnecessarily scrolls horizontally, because Bootstrap can't seem to size it correctly if its scrollable
  • The headings for the code table in the demos probably shouldn't be part of the scrollable section
  • Padding is weird, especially at the top of words
  • I don't like how the scroll bar doesn't show up unless you start scrolling, because in some demos you might not even notice that there's more content.

@ryaanahmed
Copy link
Member Author

Thanks. I'm going to merge and make a tracking issue for these improvements.

@equationcrunchor
Copy link
Collaborator

Alright, thanks!

@ryaanahmed ryaanahmed merged commit 0d1ef67 into master May 16, 2019
@ryaanahmed ryaanahmed deleted the sims_panels branch May 16, 2019 18:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants