Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

26 do not exit with fatal error on unknown transactions #29

Merged

Conversation

dhojayev
Copy link
Owner

@dhojayev dhojayev commented Jun 6, 2024

  • added error wrapping in transaction model builder
  • added unknown transaction type
  • added tests to ensure that unknown and unsupported transactions will not crash the app
  • Refactored error names
  • Changed SubAmount type to ResponseItemAmount
  • refactored test fakes
  • added more interfaces and mocks for testing
  • refactored example generator
  • updated vscode launch configs

Dovlet Hojayev and others added 5 commits June 3, 2024 09:06
tests refactored
…not crash the app

Refactored error names
Changed `SubAmount` type to `ResponseItemAmount`
refactored test fakes
added more interfaces and mocks for testing
refactored example generator
updated vscode launch configs
@dhojayev dhojayev requested a review from dmagur June 6, 2024 21:58
@dhojayev dhojayev self-assigned this Jun 6, 2024
@dhojayev dhojayev linked an issue Jun 6, 2024 that may be closed by this pull request
@dhojayev dhojayev enabled auto-merge (squash) June 7, 2024 07:40
@dhojayev dhojayev disabled auto-merge June 7, 2024 10:24
@dhojayev dhojayev merged commit 5226221 into main Jun 7, 2024
9 checks passed
@dhojayev dhojayev deleted the 26-do-not-exit-with-fatal-error-on-unknown-transactions branch June 7, 2024 10:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Do not exit with fatal error on unknown transactions
1 participant