Filters not being injected in dynamically created iframes

[mneunomne]

It seems that we are not being able to add all the filters we need inside empty src iframes.

This is a theoretical test case. But it seems to be not hiding on Chrome and on Firefox the ad is not even rendered for some reason (might be an issue with the test script).

I suspect this is related to this issue: #1844

[mneunomne]

This should be dealing with this in theory, but this line is never reached when we need it to be.

AdNauseam/src/js/contentscript.js

Lines 1530 to 1539 in 709a8eb

	if ( result ) {
	let selectors = result.injected;
	if ( typeof selectors === 'string' && selectors.length !== 0 ) {
	//ADN tmp fix: hiding - local iframe without src
	const isSpecialLocalIframes = (location.href=="about:blank" || location.href=="") && (window.self !== window.top)
	domFilterer.addCSSRule(
	selectors,
	vAPI.hideStyle,
	{ mustInject: isSpecialLocalIframes ? true : false } // ADN
	);

because result is null.

AdNauseam/src/js/contentscript.js

Lines 1498 to 1511 in 709a8eb

	if ( ids.length !== 0 || classes.length !== 0 ) {
	messaging.send('contentscript', {
	what: 'retrieveGenericCosmeticSelectors',
	hostname,
	ids,
	classes,
	exceptions: domFilterer.exceptions,
	cost: surveyCost,
	}).then(response => {
	surveyPhase3(response);
	});
	} else {
	surveyPhase3(null);
	}

[mneunomne]

We need a test case to confirm this behavior:

2. IFrames

If an iFrame matches a cosmetic selector and has a valid 'src' attribute, processIFrame() is called. If the iFrame's 'src' and parent page have the same origin, processIFrame() selects all images within the iFrame and handles them as above. If the iFrame is cross-domain, however, we will not be able to access its contents due to "Same Origin" security restrictions. In this case, we may need to manually create a new cosmetic filter for the element of interest inside the the iFrame (and add it to adnauseam.txt).
If, on Chromium-based browsers, an iFrame is dynamically-generated, the primeLocalIFrame() function attempts to inject the usual contentscripts into the iFrame (this will happen automatically on Firefox). If the injection is successful, a console message in the addon console will read as follows:
[INJECT] Dynamic-iFrame...
You may inspect the pageStore object to find more information about the iFrame.

[mneunomne]

Some info can be found in this discussion as well: gorhill#1740

[dhowe]

Some info can be found in this discussion as well: gorhill#1740

glad you found this one :)

see also: uBlockOrigin/uBlock-issues#688

I'm going to rename this to 'dynamically-created', unless there is some other case for empty src

[mneunomne]

It seems that indeed this seems to be happening. As you can see uBlock injected the content script in the about:blank iframe windows, while Adn did not.

uBlock Origin:

Adnauseam:

[mneunomne]

@dhowe found another example:

http://mazystreams.xyz/event/manchester-city-vs-chelsea/s1.php

I can confirm this is happening since when thying to hide the ad above in Adnauseam, doesn't matter how much i add blocking filters even with $important they are not blocked.

I'm adding a high priority since this is the cause of a huge amount of ads appearing with Adnauseam.

Adnauseam, ad frame about:blank with no injected content script:

in uBlock Origin, ad frame about:blank and content script injected.

[mneunomne]

At least in the case of chrome it was suposed to be happening here:

AdNauseam/platform/chromium/vapi-background.js

Lines 1416 to 1420 in 5ada7ba

	// Also being used by ADN to inject content-scripts into dynamically-created
	// iframes, as Chrome does not inject into these by default. This is needed
	// because we often can't block the iframe outright, as we need the ads inside.
	//
	vAPI.onLoadAllCompleted = function(tabId, frameId) { //ADN

[mneunomne]

Tested, closing