fix(build): move orientation to separate file to exclude cycle import

dhutaryan · Aug 21, 2023 · d38d307 · d38d307
1 parent 74cea0b
commit d38d307
Show file tree

Hide file tree

Showing 7 changed files with 9 additions and 11 deletions.
diff --git a/projects/mat-timepicker/src/lib/clock-dials.ts b/projects/mat-timepicker/src/lib/clock-dials.ts
@@ -15,7 +15,7 @@ import { TimeAdapter } from './adapter';
 import { MatTimeFaceBase } from './time-face-base';
 import { withZeroPrefixMeridiem } from './time-input-base';
 import { MatTimepickerIntl } from './timepicker-intl';
-import { TimepickerOrientation } from './timepicker-base';
+import { TimepickerOrientation } from './orientation';
 
 export type MatDialView = 'hours' | 'minutes';
 

diff --git a/projects/mat-timepicker/src/lib/orientation.ts b/projects/mat-timepicker/src/lib/orientation.ts
@@ -0,0 +1,2 @@
+/** Possible options for the timepicker orientation (dial mode only). */
+export type TimepickerOrientation = 'horizontal' | 'vertical';
diff --git a/projects/mat-timepicker/src/lib/timepicker-base.ts b/projects/mat-timepicker/src/lib/timepicker-base.ts
@@ -50,6 +50,7 @@ import {
   MatTimeSelectionModel,
 } from './time-selection-model';
 import { MAT_DEFAULT_ACITONS } from './timepicker-actions-default';
+import { TimepickerOrientation } from './orientation';
 
 /** Possible options for the timepicker to open. */
 export type TimepickerOpenAs = 'dialog' | 'popup';
@@ -66,9 +67,6 @@ export type TimepickerMode = 'input' | 'dial';
 /** Possible options for the timepicker period format. */
 export type TimepickerFormat = '12h' | '24h';
 
-/** Possible options for the timepicker orientation (dial mode only). */
-export type TimepickerOrientation = 'horizontal' | 'vertical';
-
 /** Form control that can be associated with a timepicker. */
 export interface MatTimepickerControl<T> {
   disabled: boolean;

diff --git a/projects/mat-timepicker/src/lib/timepicker-content-layout.ts b/projects/mat-timepicker/src/lib/timepicker-content-layout.ts
@@ -5,7 +5,7 @@ import {
   ViewEncapsulation,
 } from '@angular/core';
 
-import { TimepickerOrientation } from './timepicker-base';
+import { TimepickerOrientation } from './orientation';
 
 @Component({
   selector: 'mat-timepicker-content-layout',

diff --git a/projects/mat-timepicker/src/lib/timepicker-content.ts b/projects/mat-timepicker/src/lib/timepicker-content.ts
@@ -17,14 +17,11 @@ import {
   MatTimeSelectionModel,
 } from './time-selection-model';
 import { matTimepickerAnimations } from './timepicker-animations';
-import {
-  MatTimepickerBase,
-  TimepickerMode,
-  TimepickerOrientation,
-} from './timepicker-base';
+import { MatTimepickerBase, TimepickerMode } from './timepicker-base';
 import { MatTimepickerIntl } from './timepicker-intl';
 import { MatClockDials } from './clock-dials';
 import { MatTimeInputs } from './time-inputs';
+import { TimepickerOrientation } from './orientation';
 
 // Boilerplate for applying mixins to MatTimepickerContent.
 const _MatTimepickerContentBase = mixinColor(

diff --git a/projects/mat-timepicker/src/lib/timepicker.spec.ts b/projects/mat-timepicker/src/lib/timepicker.spec.ts
@@ -29,7 +29,6 @@ import { MatTimepicker } from './timepicker';
 import {
   MAT_TIMEPICKER_DEFAULT_OPTIONS,
   TimepickerOpenAs,
-  TimepickerOrientation,
 } from './timepicker-base';
 import { MatTimepickerInput } from './timepicker-input';
 import { MAT_TIMEPICKER_SCROLL_STRATEGY } from './timepicker-scroll-strategy';
@@ -40,6 +39,7 @@ import {
   getDialCell,
   getMinuteCellIndex,
 } from './clock-dials.spec';
+import { TimepickerOrientation } from './orientation';
 
 describe('MatTimepicker', () => {
   const SUPPORTS_INTL = typeof Intl != 'undefined';

diff --git a/projects/mat-timepicker/src/public-api.ts b/projects/mat-timepicker/src/public-api.ts
@@ -19,3 +19,4 @@ export * from './lib/timepicker-actions-default';
 export * from './lib/adapter';
 export * from './lib/timepicker-scroll-strategy';
 export * from './lib/timepicker-intl';
+export * from './lib/orientation';
Original file line number	Diff line number	Diff line change
		@@ -0,0 +1,2 @@
		/** Possible options for the timepicker orientation (dial mode only). */
		export type TimepickerOrientation = 'horizontal' \| 'vertical';