Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TimelineEditor: Attempting to undo a change in the text editor will irreversibly delete the entire timeline #1817

Closed
McStebb opened this issue Oct 20, 2023 · 1 comment · Fixed by #1881
Closed

TimelineEditor: Attempting to undo a change in the text editor will irreversibly delete the entire timeline #1817

McStebb opened this issue Oct 20, 2023 · 1 comment · Fixed by #1881
Labels
Bug 🐞 Something isn't working Critical 💩 Needs testing More feedback/testing would be good Planned This will be worked on soon
Milestone
Version 2.0 (beta)

Comments

@McStebb
Copy link

McStebb commented Oct 20, 2023 •
edited
Loading

The problem

Describe the bug
If you are working in the Timeline Text Editor and you press Ctrl+Z one too many times (or press it without making any changes), the entire timeline will be deleted. It will then immediately auto-save, making it impossible to recover unless you have source control and can recover it from a previous version.

To Reproduce
Steps to reproduce the behavior:

  1. Open a Timeline in the Dialogic editor
  2. Switch to Text Editor mode
  3. Click somewhere to place your cursor
  4. Ctrl+Z, as if you are trying to undo
  5. The entire timeline will delete itself & autosave, making it totally unrecoverable

Closing Godot without saving doesn't recover the timeline. Thankfully I have source control set up so I was able to recover it, but this will probably bite me again.

Expected behavior
My change is undone

System (please complete the following information):

  • OS: Windows 10 64bit
  • Godot Version: 4.1.1.stable.mono.official
  • Dialogic Version: 2.0-Alpha-9

Solutions

Workaround

Make sure that your project has source control set up so you can roll back to previous versions in case you accidentally Thanos Snap your timeline.

Possible fixes

Perhaps undo history isn't implemented yet.

Really loving Dialogic so far, lads! I appreciate the hard work. (/gen)
@McStebb McStebb changed the title Attempting to undo a change in the text editor will irreversibly delete the entire timeline TimelineEditor: Attempting to undo a change in the text editor will irreversibly delete the entire timeline Oct 20, 2023
@McStebb
Copy link
Author

McStebb commented Oct 20, 2023

Here's a screenshot of the error that appears in the Output console when you press the Ctrl+Z undo shortcut

image

@Jowan-Spooner Jowan-Spooner added Bug 🐞 Something isn't working Critical 💩 Needs testing More feedback/testing would be good labels Oct 20, 2023
@Jowan-Spooner Jowan-Spooner added this to the Version 2.0 (beta) milestone Oct 20, 2023
@Jowan-Spooner Jowan-Spooner added the Planned This will be worked on soon label Nov 7, 2023
Jowan-Spooner added a commit that referenced this issue Nov 7, 2023
@Jowan-Spooner
Make sure undo history of text editor is cleared on load
12c98d9 
Fix #1817
@Jowan-Spooner Jowan-Spooner mentioned this issue Nov 7, 2023
Merged
Jowan-Spooner added a commit that referenced this issue Nov 7, 2023
@Jowan-Spooner
Multiple improvements (#1881)
a4b31e4 
* Allow a .png icon in the repo (update to gitignore)

* Make sure undo history of text editor is cleared on load

Fix #1817

* Clear up character editor scripts

- also fix #1830
- fixes type sound (per portrait) visibility update

* Remove print

* Improve DGH

Adds lot's of documentation to the DGH
- rename State.SHOWING_TEXT to State.REVEALING_TEXT
- rename _add_layout_node to add_layout_node
- reorder methods
- change to region comments
Invertex pushed a commit to Invertex/dialogic that referenced this issue Jan 26, 2024
@Jowan-Spooner @Invertex
Multiple improvements (dialogic-godot#1881)
085e93a 
* Allow a .png icon in the repo (update to gitignore)

* Make sure undo history of text editor is cleared on load

Fix dialogic-godot#1817

* Clear up character editor scripts

- also fix dialogic-godot#1830
- fixes type sound (per portrait) visibility update

* Remove print

* Improve DGH

Adds lot's of documentation to the DGH
- rename State.SHOWING_TEXT to State.REVEALING_TEXT
- rename _add_layout_node to add_layout_node
- reorder methods
- change to region comments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug 🐞 Something isn't working Critical 💩 Needs testing More feedback/testing would be good Planned This will be worked on soon
Projects
None yet
Milestone
Version 2.0 (beta)
Development

Successfully merging a pull request may close this issue.

Multiple improvements dialogic-godot/dialogic
2 participants
@Jowan-Spooner @McStebb